WIP: writtenTypes refactors #5426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this still relevant? Don't mean to bug, just going through draft PRs and seeing if this is worth keeping aroundd |
We previously discussed the potential of reducing redundancy when handling SubModules in WT. This PR was an attempt to do so and is still relevant—I remember getting stuck on the issue mentioned above but then got distracted by more important tasks. We can close this for now, and when it becomes more relevant, we can cherry-pick from it, as we have made many changes since this PR was opened. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to refactor WrittenTypes to reduce redundancy when handling SubModules.
This isn't fully working yet; I still have to resolve an issue where an extra module with an empty name appears at the root level
Example:
It might be good to see if there’s a better shape for the types before solving this issue